Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved search results to AutoSuggestedBox instead of NavigationView #105

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Dec 6, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Since changes in PR #104, the search box was not doing anything anymore.

Issue Number: #88

What is the new behavior?

Search is operational again. However the behavior changed and there is some remaining work to do.

Done:

  • Search show the result in a combo list.
  • Selecting a matching item navigates to it.
  • Typing something that gives no result shows an item "No results found".

To do in a future PR:

  • Clicking on "No results found" item or pressing [Enter] when there's no result should go to a page indicating that there is no result.
  • Pressing [Enter] when the typed query gives several suggested items should go to a page showing details about these suggested items.

Other information

image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler added the enhancement Idea of improvement of existing feature. label Dec 6, 2021
@veler veler merged commit 2832471 into main Dec 6, 2021
@veler veler deleted the searchbox branch December 6, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant